| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
| Cc: | Tomas Vondra <tv(at)fuzzy(dot)cz>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Re: [BUGS] BUG #7873: pg_restore --clean tries to drop tables that don't exist |
| Date: | 2013-11-10 23:16:16 |
| Message-ID: | 5459.1384125376@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
Andres Freund <andres(at)2ndquadrant(dot)com> writes:
> On 2013-11-10 16:28:27 -0500, Tom Lane wrote:
>> I think this is nonsense. It's only one step removed from "why do you
>> need IF EXISTS at all, you should know whether the object is there".
>> The entire point of this syntax is to not need to do detailed analysis
>> about whether the object is there.
> Well, in my opinion the IF EXISTS refers to the object type being
> dropped. I.e. with DROP TABLE it refers to the table not existing, with
> DROP TRIGGER it refers to the trigger not existing.
Then I take it you also think we should undo the changes that made
"DROP TABLE IF EXISTS foo.bar" not fail if schema foo doesn't exist?
Because after all, the schema is not the object being dropped.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2013-11-10 23:23:55 | Re: Re: [BUGS] BUG #7873: pg_restore --clean tries to drop tables that don't exist |
| Previous Message | Andres Freund | 2013-11-10 22:49:56 | Re: Postgres: PANIC: WAL contains references to invalid pages |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2013-11-10 23:23:55 | Re: Re: [BUGS] BUG #7873: pg_restore --clean tries to drop tables that don't exist |
| Previous Message | Tom Lane | 2013-11-10 23:12:20 | Re: [COMMITTERS] pgsql: Replace duplicate_oids with Perl implementation |