| From: | Petr Jelinek <petr(at)2ndquadrant(dot)com> |
|---|---|
| To: | Petr Jelinek <petr(at)2ndquadrant(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | Simon Riggs <simon(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Jaime Casanova <jaime(at)2ndquadrant(dot)com> |
| Subject: | Re: tracking commit timestamps |
| Date: | 2014-11-01 12:04:27 |
| Message-ID: | 5454CC4B.3010108@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-www |
On 01/11/14 12:19, Petr Jelinek wrote:
> Hi,
>
> thanks for review.
>
> On 01/11/14 05:45, Michael Paquier wrote:
>> Now here are a couple of comments at code level, this code seems not
>> enough baked for a commit:
>> 1) The following renaming should be done:
>> - pg_get_transaction_committime to pg_get_transaction_commit_time
>> - pg_get_transaction_extradata to pg_get_transaction_extra_data
>> - pg_get_transaction_committime_data to
>> pg_get_transaction_commit_time_data
>> - pg_get_latest_transaction_committime_data to
>> pg_get_latest_transaction_commit_time_data
>
> Makes sense.
>
On second thought, maybe those should be pg_get_transaction_committs,
pg_get_transaction_committs_data, etc.
For me the commit time thing feels problematic in the way I perceive it
- I see commit time as a point in time, where I see commit timestamp (or
committs for short) as something that can recorded. So I would prefer to
stick with commit timestamp/committs.
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2014-11-01 12:29:29 | Re: tracking commit timestamps |
| Previous Message | Petr Jelinek | 2014-11-01 11:19:32 | Re: tracking commit timestamps |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2014-11-01 12:29:29 | Re: tracking commit timestamps |
| Previous Message | Petr Jelinek | 2014-11-01 11:19:32 | Re: tracking commit timestamps |