From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | pgsql-hackers(at)postgreSQL(dot)org |
Subject: | Re: Portability issues in TAP tests |
Date: | 2014-10-29 00:17:20 |
Message-ID: | 54503210.80209@gmx.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 7/17/14 3:31 PM, Tom Lane wrote:
> My Salesforce colleagues have been complaining that the TAP tests added
> in 9.4 don't work terribly well for them. I've been poking at this,
> and I believe this is a reasonably complete list of the problems:
Quick followup:
> 1. "make [install]check-world" tries to run the TAP tests even when
> "prove" was not found by configure. I regard this as a stop-ship issue
> for 9.4; "prove" is not part of a basic Perl installation, and even if
> it were, we don't require Perl to build from a tarball.
I just sent in a proposed patch for that.
> 2. Most of the tests fail in "make check" mode, unless you already did
> "make install", because of failures to load libpq.so. The right fix for
> this seems to be to modify LD_LIBRARY_PATH and friends
This was fixed.
> 3. Many of the tests depend on Test::More's "subtest" feature,
This was changed so it doesn't fail anymore. Discussion is ongoing
about whether to keep using that feature, but it's not a fatal error
anymore.
> 4. IPC::Run isn't installed by default on RHEL, and probably not on other
> distros either. If there's a reasonably painless way to remove this
> dependency, it'd improve the portability of the tests. This is lower
> priority than the previous items, for sure.
Same as above.
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2014-10-29 00:20:29 | Re: Portability issues in TAP tests |
Previous Message | Peter Eisentraut | 2014-10-29 00:15:11 | how to handle missing "prove" |