| From: | Marko Tiikkaja <marko(at)joh(dot)to> |
|---|---|
| To: | Jeff Janes <jeff(dot)janes(at)gmail(dot)com> |
| Cc: | Abhijit Menon-Sen <ams(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Joel Jacobson <joel(at)trustly(dot)com>, Thomas Munro <munro(at)ip9(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pgcrypto: PGP signatures |
| Date: | 2014-10-27 23:44:10 |
| Message-ID: | 544ED8CA.9040206@joh.to |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 10/27/14, 11:57 PM, Jeff Janes wrote:
> Using the same script as for the memory leak, I am getting seg faults using
> this patch.
>
> gdb backtrace:
>
> #0 pfree (pointer=0x0) at mcxt.c:749
> #1 0x00007f617d7973e7 in pgp_sym_decrypt_verify_text (fcinfo=0x1d7f1f0) at
> pgp-pgsql.c:1047
Huh. That's weird. I seem to have somehow rebased an older version of
the patch from my git history. This is the copy-paste mistake Thomas
(IIRC) pointed out and I fixed weeks, if not months, ago.
I have no idea what happened so I just threw away the git history and
rebased v6 of the patch on top of master. I've also verified that the
script runs and does not leak memory. The resulting patch, v8, attached.
My apologies for wasting your time, but thanks for testing!
.marko
| Attachment | Content-Type | Size |
|---|---|---|
| pgcrypto_sigs.v8.patch | text/plain | 146.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2014-10-28 00:01:24 | Re: proposal: CREATE DATABASE vs. (partial) CHECKPOINT |
| Previous Message | Stephen Frost | 2014-10-27 23:36:03 | Re: Directory/File Access Permissions for COPY and Generic File Access Functions |