| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: jsonb generator functions |
| Date: | 2014-10-15 21:09:44 |
| Message-ID: | 543EE298.6050701@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 10/15/2014 03:54 PM, I wrote:
>
> On 10/15/2014 07:38 AM, Pavel Stehule wrote:
>>
>>
>>
>> I checked a code, and I have only two small objection - a name
>> "jsonb_object_two_arg" is not good - maybe "json_object_keys_values" ?
>
> It's consistent with the existing json_object_two_arg. In all cases I
> think I kept the names the same except for changing "json" to "jsonb".
> Note that these _two_arg functions are not visible at the SQL level -
> they are only visible in the C code.
>
> I'm happy to be guided by others in changing or keeping these names.
If we really want to change the name of json_object_two_arg, it would
probably be best to change it NOW in 9.4 before it gets out into a
production release at all.
Thoughts?
cheers
andrew
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Josh Berkus | 2014-10-15 21:12:36 | Re: Maximum number of WAL files in the pg_xlog directory |
| Previous Message | Guillaume Lelarge | 2014-10-15 20:25:16 | Re: Maximum number of WAL files in the pg_xlog directory |