| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: pg_dump: Reduce use of global variables |
| Date: | 2014-10-14 19:58:51 |
| Message-ID: | 543D807B.3090902@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On 10/14/2014 02:20 PM, Alvaro Herrera wrote:
> pg_dump: Reduce use of global variables
>
> Most pg_dump.c global variables, which were passed down individually to
> dumping routines, are now grouped as members of the new DumpOptions
> struct, which is used as a local variable and passed down into routines
> that need it. This helps future development efforts; in particular it
> is said to enable a mode in which a parallel pg_dump run can output
> multiple streams, and have them restored in parallel.
>
> Also take the opportunity to clean up the pg_dump header files somewhat,
> to avoid circularity.
>
> Author: Joachim Wieland, revised by Álvaro Herrera
> Reviewed by Peter Eisentraut
>
>
This appears to have broken MSVC builds. See
<http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=bowerbird&dt=2014-10-14%2019%3A30%3A27>
cheers
andrew
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2014-10-14 20:42:51 | pgsql: Blind attempt at fixing Win32 pg_dump issues |
| Previous Message | Alvaro Herrera | 2014-10-14 18:20:20 | pgsql: pg_dump: Reduce use of global variables |