| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>, pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: Check for GiST index tuples that don't fit on a page. |
| Date: | 2014-10-04 13:48:27 |
| Message-ID: | 542FFAAB.1000900@gmx.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On 10/4/14 12:59 AM, Tom Lane wrote:
> Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
>> We don't have portable support for %zu formats until 9.4. The
>> backpatches to 9.3 and earlier need to use %lu.
> Good point --- and something that seems like it'll be an ongoing gotcha.
> Have we got any buildfarm critters that could be configured to throw
> errors about this?
If this change had contained a test, it would have caught it.
Alternatively, we'd need to catch compiler warnings on the build farm,
but if the installation is too old to recognize %zu, who knows what else
it'll warn (or not warn) about. Eventually, users of such systems tend
point these things out, but that could take a while.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2014-10-04 14:10:09 | Re: pgsql: Check for GiST index tuples that don't fit on a page. |
| Previous Message | Tom Lane | 2014-10-04 04:59:59 | Re: pgsql: Check for GiST index tuples that don't fit on a page. |