| From: | Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Typo fixes in src/backend/rewrite/rewriteHandler.c |
| Date: | 2014-10-02 06:55:30 |
| Message-ID: | 542CF6E2.5000707@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Here is the comments in process_matched_tle() in rewriteHandler.c.
883 * such nodes; consider
884 * UPDATE tab SET col.fld1.subfld1 = x, col.fld2.subfld2 = y
885 * The two expressions produced by the parser will look like
886 * FieldStore(col, fld1, FieldStore(placeholder, subfld1, x))
887 * FieldStore(col, fld2, FieldStore(placeholder, subfld2, x))
I think the second one is not correct and should be
FieldStore(col, fld2, FieldStore(placeholder, subfld2, y))
Just like this,
891 * FieldStore(FieldStore(col, fld1,
892 * FieldStore(placeholder, subfld1, x)),
893 * fld2, FieldStore(placeholder, subfld2, x))
should be
FieldStore(FieldStore(col, fld1,
FieldStore(placeholder, subfld1, x)),
fld2, FieldStore(placeholder, subfld2, y))
Patch attached.
Thanks,
Best regards,
Etsuro Fujita
| Attachment | Content-Type | Size |
|---|---|---|
| rewriteHandler-typo-fixes.patch | text/x-patch | 1.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2014-10-02 07:07:45 | Re: UPSERT wiki page, and SQL MERGE syntax |
| Previous Message | Kyotaro HORIGUCHI | 2014-10-02 06:36:43 | Re: Escaping from blocked send() reprised. |