From: | Andrey Lepikhov <a(dot)lepikhov(at)postgrespro(dot)ru> |
---|---|
To: | Michael Paquier <michael(at)paquier(dot)xyz> |
Cc: | Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, hlinnaka(at)iki(dot)fi, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: [PATCH] XLogReadRecord returns pointer to currently read page |
Date: | 2018-11-20 01:37:36 |
Message-ID: | 5423cf66-cd12-96d0-abf0-1776d466bfaa@postgrespro.ru |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 20.11.2018 6:30, Michael Paquier wrote:
> On Mon, Nov 19, 2018 at 10:48:06AM +0500, Andrey Lepikhov wrote:
>> According to my experience, I clarify some comments to avoid this mistakes
>> in the future (see attachment).
>
> No objections from here.
>
>> - * The returned pointer (or *errormsg) points to an internal buffer that's
>> - * valid until the next call to XLogReadRecord.
>> + * The returned pointer (or *errormsg) points to an internal read-only buffer
>> + * that's valid until the next call to XLogReadRecord.
>
> Not sure that this bit adds much.
Ok
>
>> - /* Buffer for current ReadRecord result (expandable) */
>> + /*
>> + * Buffer for current ReadRecord result (expandable).
>> + * Used in the case, than current ReadRecord result don't fit on the
>> + * currently read WAL page.
>> + */
>
> Yeah, this one is not entirely true now. What about the following
> instead:
> - /* Buffer for current ReadRecord result (expandable) */
> + /*
> + * Buffer for current ReadRecord result (expandable), used when a record
> + * crosses a page boundary.
> + */
I agree
--
Andrey Lepikhov
Postgres Professional
https://postgrespro.com
The Russian Postgres Company
From | Date | Subject | |
---|---|---|---|
Next Message | Stephen Frost | 2018-11-20 01:45:29 | Re: More issues with pg_verify_checksums and checksum verification in base backups |
Previous Message | Michael Paquier | 2018-11-20 01:30:56 | Re: [PATCH] XLogReadRecord returns pointer to currently read page |