Re: proposal: rounding up time value less than its unit.

From: Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Tomonari Katsumata <t(dot)katsumata1122(at)gmail(dot)com>, David G Johnston <david(dot)g(dot)johnston(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: proposal: rounding up time value less than its unit.
Date: 2014-09-23 16:13:51
Message-ID: 54219C3F.8090108@vmware.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 09/23/2014 06:23 PM, Andrew Dunstan wrote:
>
> On 09/23/2014 10:29 AM, Tom Lane wrote:
>> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>>> Three people have voted for making it an *error* to supply a value
>>> that needs to be rounded, instead of changing the rounding behavior.
>> Votes or no votes, that's a horrible idea; it breaks the design goal
>> that users shouldn't need to remember the precise unit size when making
>> postgresql.conf entries.
>>
>> And I'm not sure what votes you're counting, anyway. People's opinions
>> have changed as the discussion proceeded ...
>
> I don't think I've weighed in on this, and yes, I'm very late to the
> party. The "round away from zero" suggestion seemed the simplest and
> most easily understood rule to me.

+1, rounding up seems better to me as well. Although throwing an error
wouldn't be that bad either.

- Heikki

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dmitry Dolgov 2014-09-23 16:23:33 JsonbValue to Jsonb conversion
Previous Message David Johnston 2014-09-23 16:03:01 Re: proposal: rounding up time value less than its unit.