From: | Josh Berkus <josh(at)agliodbs(dot)com> |
---|---|
To: | Craig Ringer <craig(at)2ndquadrant(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | "Brightwell, Adam" <adam(dot)brightwell(at)crunchydatasolutions(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>, Yeb Havinga <yeb(dot)havinga(at)portavita(dot)nl> |
Subject: | Re: RLS Design |
Date: | 2014-09-20 18:18:21 |
Message-ID: | 541DC4ED.6000302@agliodbs.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 09/20/2014 12:23 AM, Craig Ringer wrote:
> On 09/20/2014 12:38 AM, Stephen Frost wrote:
>
>> I would not (nor do I feel that I did..) have committed it over a
>> specific request to not do so from another committer. I had been hoping
>> that there would be another review coming from somewhere, but there is
>> always a trade-off between waiting longer to get a review ahead of a
>> commit and having it committed and then available more easily for others
>> to work with, review, and generally moving forward.
>
> Y'know what helps with that? Publishing clean git branches for
> non-trivial work, rather than just lobbing patches around.
>
> I'm finding the reliance on a patch based workflow increasingly
> frustrating for complex work, and wonder if it's time to revisit
> introducing a git repo+ref to the commitfest app.
>
> I find the need to find the latest patch on the list, apply it, and fix
> it up really frustrating. "git am --3way" helps a lot, but only if the
> patch is created with "git format-patch".
>
> Perhaps it's time to look at whether git can do more to help us with the
> testing and review process.
We discussed this at the last developer meeting, without coming up with
a written procedure. Your ideas can help ...
--
Josh Berkus
PostgreSQL Experts Inc.
http://pgexperts.com
From | Date | Subject | |
---|---|---|---|
Next Message | Josh Berkus | 2014-09-20 18:33:35 | Re: Yet another abort-early plan disaster on 9.3 |
Previous Message | Dimitri Fontaine | 2014-09-20 18:16:02 | Re: pgsql: Row-Level Security Policies (RLS) |