Re: pgsql: Fix contrib/auto_explain to not cause problems in parallel worke

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Fix contrib/auto_explain to not cause problems in parallel worke
Date: 2019-06-04 01:16:56
Message-ID: 54159.1559611016@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Michael Paquier <michael(at)paquier(dot)xyz> writes:
> On Mon, Jun 03, 2019 at 10:06:21PM +0000, Tom Lane wrote:
>> Fix contrib/auto_explain to not cause problems in parallel workers.

> This has broken the builds on Windows for 9.6 and 10:
> https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=woodlouse&dt=2019-06-04%2000%3A42%3A07&stg=make

Ooops.

> This gets included as a dependency because of the call to
> IsParallelWorker() you have added in this commit, and I think that
> this can be fixed by adding PGDLLIMPORT to the variable in
> parallel.h. Would you fix it or should I?

Yeah, I see we already did that in later branches. I'll go fix it,
thanks for the heads-up!

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2019-06-04 01:26:04 pgsql: Mark a few parallelism-related variables with PGDLLIMPORT.
Previous Message Michael Paquier 2019-06-04 01:13:54 Re: pgsql: Fix contrib/auto_explain to not cause problems in parallel worke