| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, KaiGai Kohei <kaigai(at)kaigai(dot)gr(dot)jp>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: refactoring comment.c |
| Date: | 2010-08-19 15:57:20 |
| Message-ID: | 5414.1282233440@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> Excerpts from Robert Haas's message of mi ago 18 21:32:48 -0400 2010:
>> Here's v3.
> The header comment in objectaddress.c contains a funny mistake: it says
> it works with ObjectAddresses. However, ObjectAddresses is a different
> type altogether, so I recommend not using that as plural for
> ObjectAddress. Maybe "ObjectAddress objects"? :-D
Alternatively, maybe ObjectAddresses was a bad choice of type name,
and it should be ObjectAddressList or ObjectAddressArray or some such.
But changing that might be more trouble than it's worth.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2010-08-19 16:12:52 | Re: refactoring comment.c |
| Previous Message | David Fetter | 2010-08-19 15:48:53 | Re: Fw: patch for pg_ctl.c to add windows service start-type |