| From: | Vik Fearing <vik(dot)fearing(at)dalibo(dot)com> |
|---|---|
| To: | Stephen Frost <sfrost(at)snowman(dot)net> |
| Cc: | Marko Tiikkaja <marko(at)joh(dot)to>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Bruce Momjian <bruce(at)momjian(dot)us>, dmigowski(at)ikoffice(dot)de, PG Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [BUGS] BUG #10823: Better REINDEX syntax. |
| Date: | 2014-09-10 21:43:30 |
| Message-ID: | 5410C602.1040905@dalibo.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
On 09/08/2014 06:17 AM, Stephen Frost wrote:
> * Vik Fearing (vik(dot)fearing(at)dalibo(dot)com) wrote:
>> On 09/02/2014 10:17 PM, Marko Tiikkaja wrote:
>>> Yeah, I think I like this better than allowing all of them without the
>>> database name.
>>
>> Why? It's just a noise word!
>
> Eh, because it ends up reindexing system tables too, which is probably
> not what new folks are expecting.
No behavior is changed at all. REINDEX DATABASE dbname; has always hit
the system tables. Since dbname can *only* be the current database,
there's no logic nor benefit in requiring it to be specified.
> Also, it's not required when you say
> 'user tables', so it's similar to your user_tables v1 patch in that
> regard.
The fact that REINDEX USER TABLES; is the only one that doesn't require
the dbname seems very inconsistent and confusing.
>> Yes, I will update the patch.
>
> Still planning to do this..?
>
> Marking this back to waiting-for-author.
Yes, but probably not for this commitfest unfortunately.
--
Vik
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stephen Frost | 2014-09-10 21:53:10 | Re: [BUGS] BUG #10823: Better REINDEX syntax. |
| Previous Message | Bruce Momjian | 2014-09-10 21:13:51 | Re: Re: BUG #10329: Could not read block 0 in file "base/56100265/57047884": read only 0 of 8192 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stephen Frost | 2014-09-10 21:50:05 | Re: RLS Design |
| Previous Message | Bruce Momjian | 2014-09-10 21:13:18 | Re: Need Multixact Freezing Docs |