Re: holdable cursors

Neil Conway <neilc(at)samurai(dot)com> writes:
> - I needed to change the tuple store API slightly -- it assumes that it
> won't be used to hold data across transaction boundaries, so the temp
> files that it uses for on-disk storage are automatically reclaimed at
> end-of-transaction. I added a flag to tuplestore_begin_heap() to control
> this behavior. Is changing the tuple store API in this fashion OK?

What do you do to ensure the temp files *do* get cleaned up eventually?

> To workaround this, I've temporarily hacked up a solution
> that works,

I'm not real pleased with the fact that this patch has already been
applied while it still contains a "temporary hack". Please fix this
soon.

regards, tom lane