Re: improve installation short version

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: improve installation short version
Date: 2021-06-03 12:33:05
Message-ID: 54002bc0-6653-bcd4-fca3-5679535bdfe0@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 6/2/21 5:36 PM, Tom Lane wrote:
> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>> On 6/2/21 4:58 PM, Mark Dilger wrote:
>>> Prior to where your patch makes changes, the docs say, "If you are building PostgreSQL for Microsoft Windows, read this chapter if you intend to build with MinGW or Cygwin". I think going on to tell the users to use `su` is a bit odd. Does that exist in standard MinGW and Cygwin environments? I thought "run as" was the Windows option for this.
>> Yes, good point. We should fix that. Yes, "runas" is a sort of su.
>> There's no adduser either.
> There's a whole lot of Unix systems that don't spell that command
> as "adduser", either. That whole recipe has to be understood as
> a guide, not something you can blindly copy-and-paste.
>
> Maybe what we really need is an initial disclaimer saying something
> along the lines of "Here's approximately what you need to do; adapt
> these commands per local requirements."
>
> And then, perhaps, change the last line to "For more detail, see
> the rest of this chapter".
>
>

Ok, patch attached

cheers

andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

Attachment Content-Type Size
short-version-comments-2.patch text/x-patch 1.1 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2021-06-03 12:36:06 Re: A few source files have the wrong copyright year
Previous Message Daniel Gustafsson 2021-06-03 12:30:16 Re: A few source files have the wrong copyright year