Re: proposal: rpm package for plpgsql_check

On 08/25/2014 03:57 PM, Pavel Stehule wrote:
> Hi
>
> I prepared a spec file for plpgsql_check
>
> https://github.com/okbob/plpgsql_check/blob/master/plpgsql_check.spec
>
> please, can you integrate it?

It doesn't look ready.

%global pgmajorversion 9

should be

%global pgmajorversion 94

i.e. the full PostgreSQL major version in short form.

It should make sure to install the extension into the correct
/usr/pgsql-9.4/lib, /usr/pgsql-9.4/share/extension, etc, probably with
appropriate %files macros .

The %description should be about what the package does, not why it
exists. That material can go in a /usr/share/doc/%{name}/README.rpm-dist
if it's RPM-specific, or just in the regular README.

The package makes no attempt to set PATH or an explicit pg_config
location, so it might not build against the correct PostgreSQL if more
than one is installed.

Ideally the requires should be arch-qualified, e.g.

BuildRequires: postgresql%{pgmajorversion}-devel%{_?isa}
Requires: postgresql%{pgmajorversion}%{_?isa}

--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services