| From: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
|---|---|
| To: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgreSQL(dot)org> |
| Subject: | Re: [COMMITTERS] pgsql: Move log_newpage and log_newpage_buffer to xlog.c. |
| Date: | 2014-07-31 14:48:08 |
| Message-ID: | 53DA5728.6070002@iki.fi |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On 07/31/2014 05:19 PM, Simon Riggs wrote:
> On 31 July 2014 14:59, Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi> wrote:
>
>> Move log_newpage and log_newpage_buffer to xlog.c.
>
> Got a feeling this wasn't properly discussed because its unlikely
> anybody would agree with adding more stuff to xlog.c
Well, they certainly don't belong in heapam.c... Got a better suggestion?
(I bumped into this again while working on the WAL format & API changes,
which understandably rewrites those functions again. It seemed better to
do this refactoring separately than include it in the huge patch.)
- Heikki
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2014-07-31 14:58:59 | Re: [COMMITTERS] pgsql: Move log_newpage and log_newpage_buffer to xlog.c. |
| Previous Message | Simon Riggs | 2014-07-31 14:19:57 | Re: pgsql: Move log_newpage and log_newpage_buffer to xlog.c. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2014-07-31 14:58:59 | Re: [COMMITTERS] pgsql: Move log_newpage and log_newpage_buffer to xlog.c. |
| Previous Message | Simon Riggs | 2014-07-31 14:19:57 | Re: pgsql: Move log_newpage and log_newpage_buffer to xlog.c. |