Incorrect comment in postgres_fdw.c

From: Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>
To: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Incorrect comment in postgres_fdw.c
Date: 2014-07-11 09:22:04
Message-ID: 53BFACBC.9000503@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I think the following comment for store_returning_result() in
postgres_fdw.c is not right.

/* PGresult must be released before leaving this function. */

I think PGresult should not be released before leaving this function *on
success* in that function.

(I guess the comment has been copied and pasted from that for
get_remote_estimate().)

Thanks,

Best regards,
Etsuro Fujita

Attachment Content-Type Size
postgres_fdw-comment.patch text/x-diff 436 bytes

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2014-07-11 09:23:21 Re: tweaking NTUP_PER_BUCKET
Previous Message Magnus Hagander 2014-07-11 09:18:58 Re: pg_receivexlog and replication slots