From: | "gotoschool6g" <gotoschool6g(at)gmail(dot)com> |
---|---|
To: | "Abhijit Menon-Sen" <ams(at)2ndQuadrant(dot)com> |
Cc: | "pgsql-hackers" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: pg_xlogdump --stats |
Date: | 2014-07-04 10:31:34 |
Message-ID: | 53B68281.1080507@gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
>
> I'm pretty sure that most committers would want to apply the
> rm_identity part in a separate commit first. Could you make it
> two patches, one introducing rm_identity, and another with
> xlogdump using it?
Carp the code:
const char *
clog_identify(uint8 info)
{
switch (info)
{
case CLOG_ZEROPAGE:
return "ZEROPAGE";
case CLOG_TRUNCATE:
return "TRUNCATE";
break;
}
return NULL;
}
or
const char *
clog_identify(uint8 info)
{
if(info==CLOG_ZEROPAGE)return "ZEROPAGE";
if(info==CLOG_TRUNCATE)return "TRUNCATE";
return NULL;
}
is a bit faster than:
const char *
clog_identify(uint8 info)
{
const char *id = NULL;
switch (info)
{
case CLOG_ZEROPAGE:
id = "ZEROPAGE";
break;
case CLOG_TRUNCATE:
id = "TRUNCATE";
break;
}
return id;
}
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2014-07-04 10:36:17 | Re: pg_xlogdump --stats |
Previous Message | Andres Freund | 2014-07-04 10:11:48 | Re: No toast table for pg_shseclabel but for pg_seclabel |