[PATCH] Fix crash during connect using SSPI auth

From: Nikhil Deshpande <ndeshpande(at)vmware(dot)com>
To: pgsql-odbc(at)postgresql(dot)org
Subject: [PATCH] Fix crash during connect using SSPI auth
Date: 2014-06-23 21:02:38
Message-ID: 53A895EE.9040902@vmware.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-odbc

Hi,

I ran into a crash in psqlodbc driver on Windows while trying to connect
using SSPI authentication (both client and server are on same Windows
host, using a Windows local account instead of domain account, without
any Kerberos setup).

The crash is due to a NULL pointer dereference in function
extract_extra_attribute_setting(), ci->conn_settings.name was
NULL in caller MakePrincHint():

1741 char *extract_extra_attribute_setting(const pgNAME setting, ...
1742 {
1743 const char *str = GET_NAME(setting);
...
1750 for (cptr = str; *cptr; cptr++) <-- *cptr crashes

Please see attached stack trace for more details.

With attached patch, connection using SSPI authentication was
successful.

Thanks,
Nikhil

Attachment Content-Type Size
stacktrace.txt text/plain 1.9 KB
0001-Fix-crash-during-connect-using-SSPI-auth.patch text/plain 1013 bytes

Responses

Browse pgsql-odbc by date

  From Date Subject
Next Message Inoue, Hiroshi 2014-06-23 21:23:17 Re: msdtc with 32-bit app fails to resolve in-doubt or not-notifed transactions
Previous Message Inoue, Hiroshi 2014-06-23 20:58:17 Re: Non-ASCII DSN name troubles