Re: idle_in_transaction_timeout

From: Vik Fearing <vik(dot)fearing(at)dalibo(dot)com>
To: Andres Freund <andres(at)2ndquadrant(dot)com>, Kevin Grittner <kgrittn(at)ymail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Josh Berkus <josh(at)agliodbs(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>
Subject: Re: idle_in_transaction_timeout
Date: 2014-06-23 11:33:46
Message-ID: 53A8109A.6070902@dalibo.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 06/22/2014 07:47 PM, Andres Freund wrote:
> On 2014-06-22 09:27:24 -0700, Kevin Grittner wrote:
>> Andres Freund <andres(at)2ndquadrant(dot)com> wrote:
>>
>>> The idea with the GUC name is that if we ever get support for
>>> cancelling transactions we can name that
>>> idle_in_transaction_transaction_timeout?
>>> That seems a bit awkward...
>>
>> No, the argument was that for all the other *_timeout settings what
>> came before _timeout was the thing that was being terminated. I
>> think there were some votes in favor of the name on that basis, and
>> none against. Feel free to give your reasons for supporting some
>> other name.
>
> My reasons for not liking the current GUC name are hinted at above. I think
> we'll want a version of this that just fails the transaction once we
> have the infrastructure. So we should choose a name that allows for
> a complimentary GUC.
> CAKFQuwZCg2uur=tUdz_C2aUwBo87ofFGhn9Mx_HZ4QD-b8fe2Q(at)mail(dot)gmail(dot)com
> suggested
> On 2014-06-19 10:39:48 -0700, David G Johnston wrote:
>> "idle_in_transaction_timeout=10s"
>> "idle_in_transaction_target=session|transaction"
>
> but I don't like that much. Not sure what'd be good, the best I
> currently can come up with is:
> idle_in_transaction_termination_timeout =
> idle_in_transaction_cancellation_timeout =

Except the transaction wouldn't be cancelled, it would be aborted.

idle_in_transaction_abortion_timeout seems a little... weird.
--
Vik

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2014-06-23 11:34:35 Re: idle_in_transaction_timeout
Previous Message Fujii Masao 2014-06-23 11:29:17 Re: idle_in_transaction_timeout