Re: Removing support for v1 and v2 protocols?

On 06/19/2014 06:49 AM, Michael Paquier wrote:
> On Thu, Jun 19, 2014 at 11:52 AM, Craig Ringer <craig(at)2ndquadrant(dot)com> wrote:
>> Hi
>>
>> I've just found a bug (followup mail to come) that seems to be tied up
>> in support for the old v1/v2 protocols.
>>
>> Is there any reason to keep all that cruft? v3 was introduced in 7.4, in
>> 2003-11-17 .
>>
>> Also, I'm wondering why psqlODBC does so much of its own protocol
>> handling. It links to libpq, why doesn't it use it? There's a lot of
>> complicated code in there - see, e.g. CC_send_query_append, that seems
>> to duplicate much of what libpq its self does, and mix protocol handling
>> up with client driver logic.
>
> Please see here:
> http://www.postgresql.org/message-id/CAB7nPqRuxEuBgM-us4oKsc-rB6qN84CgsOC8M0O+pyW2d_GUKA@mail.gmail.com
> The plan is to wait a couple of weeks before Postgres 9.4 and then
> integrate that in the driver for the first 9.4-XXXX release of the
> ODBC driver. For now, this work is periodically rebased and stored on
> my own pgodbc fork on github.

I'm getting eager to move ahead with this. In addition to Michael's
cleanup, I have a bunch of other changes queued up that are such big
changes that it would be nice to do them while bumping the major version
number:

1. Switch to MSBuild-based build system on Windows.

2. Link msdtc_enlist.cpp directly into the main DLL.
http://www.postgresql.org/message-id/53A57080.1070501@vmware.com

3. Deal with Unicode in DSN names and other config options. (Subject
"Non-ASCII DSN name troubles", post stalled ATM)

I propose the following:

* Do one more release of the 09.03.XXXX series, from the current git
master. Right now. There are a bunch of bug fixes there that people are
probably waiting for.

* After that last 09.03.XXXX release, bump the major version number in
git master to 09.04.0000 and commit all of those bigger patches.

Any objections? Could someone wrap a new release, please?

- Heikki