Re: Running regression tests on Windows

On 06/18/2014 03:18 PM, Michael Paquier wrote:
> On Wed, Jun 18, 2014 at 9:03 PM, Heikki Linnakangas
> <hlinnakangas(at)vmware(dot)com> wrote:
>> On 06/13/2014 03:39 AM, Michael Paquier wrote:
>>>>
>>>>> Oh. I don't think that's really necessary. Windows can handle relative
>>>>> paths
>>>>> just fine. With the \! syntax, though, it seems that Windows wants an
>>>>> extra
>>>>> pair of quotes. So this works:
>>>>>
>>>>> \! "src/<testname>-test"
>>>>>
>>>>> That also works on Unix, although the extra quotes are not necessary
>>>>> there,
>>>>> so let's just do that.
>>>
>>> OK good to know. I didn't think about that when writing this patch.
>>
>> On further testing, that only works on Windows with psql version 9.4 or
>> later. Maybe we can live with that..
> Ouch OK. Is there any reason specific to psql for that?

Older versions didn't quote the command passed to CMD properly. That was
fixed in 9.4, but not backpatched, in fear that it would break people's
scripts that currently include an extra pair of quotes in the command,
to work around that. See commit
http://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=a692ee5870f0f442565b4c4bff367094599e9bdf

- Heikki