Re: buildfarm animals and 'snapshot too old'

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Tomas Vondra <tv(at)fuzzy(dot)cz>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: buildfarm animals and 'snapshot too old'
Date: 2014-05-21 15:33:18
Message-ID: 537CC73E.7060204@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 05/20/2014 09:42 AM, Tom Lane wrote:

>> Regarding clock skew, I think we can do better then what you suggest.
>> The web transaction code in the client adds its own timestamp just
>> before running the web transaction. It would be quite reasonable to
>> reject reports from machines with skewed clocks based on this value. I'm
>> not sure what a reasonable skew might be. Somewhere in the range of 5 to
>> 15 minutes seems reasonable.
> Rather than reject, why not take the result and adjust the claimed start
> timestamp by the difference between the web transaction timestamp and the
> buildfarm server's time?

Right now I have added some logging of clock skew to see what we're
actually getting.

It won't be visible in the Web UI, but when I have some data I will post
more info.

cheers

andrew

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Vik Fearing 2014-05-21 16:10:39 Re: Bison 3.0 updates
Previous Message Bruce Momjian 2014-05-21 14:49:43 Re: pg_upgrade fails: Mismatch of relation OID in database 8.4 -> 9.3