Re: Commit ad2a4ae causing more damages than fixes in regression tests

On 05/19/2014 05:32 AM, Michael Paquier wrote:
> Saito-san,
>
> On Fri, May 16, 2014 at 11:37 PM, Hiroshi Saito <hiroshi(at)winpg(dot)jp> wrote:
>> Um, it has not been released yet, and it is not in my test case.:-(
>> I don't know whether desire it now. However,require in the future.
> After some more testing, I am seeing that the diffs in test
> catalogfunction that you have introduced with commit ad2a4ae are
> reproducible down to 8.4 (didn't go further down):
> *** /Users/ioltas/git/pgodbc/test/expected/catalogfunctions.out Fri
> May 16 08:13:36 2014
> --- /Users/ioltas/git/pgodbc/test/results/catalogfunctions.out Mon
> May 19 11:25:36 2014
> ***************
> *** 186,196 ****
> contrib_regression public testtab1 _SYSTEM UPDATE YES
> contrib_regression public testtab1 _SYSTEM DELETE YES
> contrib_regression public testtab1 _SYSTEM REFERENCES YES
> - contrib_regression public testtab1 _SYSTEM INSERT YES
> - contrib_regression public testtab1 _SYSTEM SELECT YES
> - contrib_regression public testtab1 _SYSTEM UPDATE YES
> - contrib_regression public testtab1 _SYSTEM DELETE YES
> - contrib_regression public testtab1 _SYSTEM REFERENCES YES
> Result set:
> contrib_regression public testtab1 TABLE
> contrib_regression public testtab_fk TABLE
> --- 186,191 ----
>
> Could you provide the configuration files you have been using for your
> tests? I am afraid that I am not able to understand why you are seeing
> such diffs. Heikki, are you noticing that?

Yep. The expected output in git at the moment is just wrong.

> This may be as well a bug in the ODBC code, it is somewhat weird to
> see two times the same permission entries for the same table
> (testtab1) when calling SQLTablePrivileges.

Yeah. If there is a configuration that actually produces that output,
then it sure looks like a bug in the code.

- Heikki