Re: improve ssl error code, 2147483650

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Stephen Frost <sfrost(at)snowman(dot)net>
Cc: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, David Zhang <david(dot)zhang(at)highgo(dot)ca>, Pgsql Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: improve ssl error code, 2147483650
Date: 2024-03-07 17:52:12
Message-ID: 537905.1709833932@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Stephen Frost <sfrost(at)snowman(dot)net> writes:
> * Heikki Linnakangas (hlinnaka(at)iki(dot)fi) wrote:
>> That's pretty unfortunate. As typical with OpenSSL, this stuff is not very
>> well documented, but I think we could do something like this in
>> SSLerrmessage():
>>
>> if (ERR_SYSTEM_ERROR(e))
>> errreason = strerror(ERR_GET_REASON(e));
>>
>> ERR_SYSTEM_ERROR only exists in OpenSSL 3.0 and above, and the only
>> documentation I could find was in this one obscure place in the man pages: https://www.openssl.org/docs/man3.2/man3/BIO_dgram_get_local_addr_enable.html.
>> But as a best-effort thing, it would still be better than "SSL error code
>> 2147483650".

> Agreed that it doesn't seem well documented. I was trying to figure out
> what the 'right' answer here was myself and not having much success. If
> the above works, then +1 to that.

My reaction as well --- I was just gearing up to test this idea,
unless one of you are already on it?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2024-03-07 17:53:01 Re: Potential stack overflow in incremental base backup
Previous Message Nathan Bossart 2024-03-07 17:33:18 Re: Popcount optimization using AVX512