| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | gomer94(at)yandex(dot)ru, pgsql-bugs(at)postgresql(dot)org |
| Subject: | Re: BUG #14867: Cascade drop type error |
| Date: | 2017-10-23 16:33:52 |
| Message-ID: | 5379.1508776432@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
Andres Freund <andres(at)anarazel(dot)de> writes:
> On 2017-10-23 12:09:24 -0400, Tom Lane wrote:
>> Cute. Type my_type isn't exposed as a dependency of the view,
>> because it's only referenced internally in the expression tree
>> not as a result column type. We can fix that easily enough by
>> teaching dependency.c to log the result type of a FieldSelect
>> as a dependency.
> That does remind me of patch 0001 in
> http://archives.postgresql.org/message-id/20170314224706.nxvtapenky6eom3z%40alap3.anarazel.de
It is in the same part of the code, but seems directed at a different
goal (which I disapproved of, IIRC). But we definitely need the
principle that any type OID appearing in an expression tree needs to
be logged, except in cases where there's necessarily an indirect
dependency (eg, a function or operator's result type doesn't need to
be logged separately).
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Chris Hanks | 2017-10-23 16:38:27 | Re: Connections hang indefinitely while taking a LWLockTranche buffer_content lock. |
| Previous Message | Andres Freund | 2017-10-23 16:17:26 | Re: BUG #14867: Cascade drop type error |