Re: pgsql: plperl: windows: Use Perl_setlocale on 5.28+, fixing compile fai

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org, Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>
Subject: Re: pgsql: plperl: windows: Use Perl_setlocale on 5.28+, fixing compile fai
Date: 2022-01-31 02:01:07
Message-ID: 535668.1643594467@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Andres Freund <andres(at)anarazel(dot)de> writes:
> On 2022-01-30 17:35:48 -0800, Andres Freund wrote:
>> I see this broke on everywhere but master. Looking.

> Ugh. It's that we didn't backport pport.h.

Ooops.

> Unless somebody comes up with a better idea quickly I'm going use a plain
> PERL_VERSION check in the backbranches. Might also be a good idea to backpatch
> the above commit, but that requires more discussion than I want to leave the
> buildfarm red for.

I think we oughta backport. We didn't do so at the time because
we thought it was mostly cosmetic/future-proofing, but evidently
the future is now.

I can look into that tomorrow or so.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2022-01-31 02:05:17 pgsql: plperl: Fix breakage of c89f409749c in back branches.
Previous Message Andres Freund 2022-01-31 01:51:30 Re: pgsql: plperl: windows: Use Perl_setlocale on 5.28+, fixing compile fai