Re: pgsql: Add ANALYZE into regression tests

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Stephen Frost <sfrost(at)snowman(dot)net>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Add ANALYZE into regression tests
Date: 2014-04-13 12:40:33
Message-ID: 534A85C1.2060902@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers


On 04/13/2014 12:42 AM, Stephen Frost wrote:
> Add ANALYZE into regression tests
>
> Looks like we can end up with different plans happening on the
> buildfarm, which breaks the regression tests when we include
> EXPLAIN output (which is done in the regression tests for
> updatable security views, to ensure that the user-defined
> function isn't pushed down to a level where it could view the
> rows before the security quals are applied).
>
> This adds in ANALYZE to hopefully make the plans consistent.
> The ANALYZE ends up changing the original plan too, so the
> update looks bigger than it really is. The new plan looks
> perfectly valid, of course.
>
>

Are you really sure we can do this consistently? The regression tests
have to run against all sorts of settings, including those we have no
control over via installcheck.

cheers

andrew

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Stephen Frost 2014-04-13 12:48:30 Re: pgsql: Add ANALYZE into regression tests
Previous Message Stephen Frost 2014-04-13 05:10:15 Re: [COMMITTERS] pgsql: Add ALTER TABLESPACE ... MOVE command

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephen Frost 2014-04-13 12:48:30 Re: pgsql: Add ANALYZE into regression tests
Previous Message Christian Ullrich 2014-04-13 12:29:13 Re: PostgreSQL in Windows console and Ctrl-C