Re: Another assert failure from no-palloc-in-critical-sections

From: Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: Another assert failure from no-palloc-in-critical-sections
Date: 2014-04-05 19:19:02
Message-ID: 53405726.90409@vmware.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 04/05/2014 08:08 PM, Tom Lane wrote:
> I tried the test case given in
> http://www.postgresql.org/message-id/dafad644f268ce1503e1b8b682aae38a.squirrel@webmail.xs4all.nl
> on HEAD. It asserted here:
>...
> #5 0x000000000046b92b in createPostingTree (index=0x7f1348ae31e0,
> items=0x7f13343bb048, nitems=272428, buildStats=0x7fff1d835670)
> at gindatapage.c:1739

Yep, that's a clear violation of the no-pallocs-in-critical-section
rule. Thanks, fixed.

I'm surprised none of the existing regression tests caught that.
Apparently none of them create a GIN index with enough duplicate keys
that it would create a posting tree. I added one.

- Heikki

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2014-04-05 20:48:33 Re: B-Tree support function number 3 (strxfrm() optimization)
Previous Message Tom Lane 2014-04-05 18:23:29 Re: trgm regex index peculiarity