From: | Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> |
---|---|
To: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | A question about code in DefineRelation() |
Date: | 2014-04-04 04:35:21 |
Message-ID: | 533E3689.2090108@lab.ntt.co.jp |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
If I understand correctly, foreign tables cannot have an OID column, but
the following code in DefineRelation() assumes that foreign tables *can*
have that coulum:
560 /*
561 * Create a tuple descriptor from the relation schema. Note
that this
562 * deals with column names, types, and NOT NULL constraints, but not
563 * default values or CHECK constraints; we handle those below.
564 */
565 descriptor = BuildDescForRelation(schema);
566
567 localHasOids = interpretOidsOption(stmt->options,
568 (relkind == RELKIND_RELATION ||
569 relkind ==
RELKIND_FOREIGN_TABLE));
Is this intended to support an OID column on foreign tables in future?
Thanks,
Best regards,
Etsuro Fujita
From | Date | Subject | |
---|---|---|---|
Next Message | Amit Kapila | 2014-04-04 04:51:09 | Re: four minor proposals for 9.5 |
Previous Message | Noah Misch | 2014-04-04 03:49:54 | Re: Securing "make check" (CVE-2014-0067) |