Re: Re: [HACKERS] New parameter RollbackError to control rollback behavior on error

From: Hiroshi Inoue <inoue(at)tpf(dot)co(dot)jp>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, PostgreSQL mailing lists <pgsql-odbc(at)postgresql(dot)org>
Subject: Re: Re: [HACKERS] New parameter RollbackError to control rollback behavior on error
Date: 2014-03-31 03:22:21
Message-ID: 5338DF6D.2030105@tpf.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-odbc

(2014/03/29 7:23), Michael Paquier wrote:
> On Sat, Mar 29, 2014 at 7:16 AM, Hiroshi Inoue <inoue(at)tpf(dot)co(dot)jp> wrote:
>> (2014/03/28 14:37), Michael Paquier wrote:
>>>
>>> On Fri, Mar 28, 2014 at 12:53 PM, Inoue, Hiroshi <inoue(at)tpf(dot)co(dot)jp> wrote:
>>> No differences. I just changed the name of this variable to be a
>>> maximum consistent with the parameter introduced.
>>
>>
>> There are some rollback_on_error in dlg_wingui.c.
> Ouch, thanks.
>
>>>> The length of connection strings seem to be increased at least 3 bytes.
>>>> Is it right?
>>>
>>> Do you mean that with the introduction of the new parameter AA? If
>>> yes, well I guess it is increased by 5 bytes ";AA=[0|1|2]".
>>
>>
>> Isn't the difference between
>> A1=7.4;AA=[0|1|2] and A1=7.4-[0|1|2]
>> ?
>> I introduced the latter only to skimp on 3 bytes.
> Oh yes, sorry. Is it a problem though? Because if we switch to
> string-only values for AA this could get longer by 10~20 bytes
> depending on the parameter values.

SQLDriverConnect() returns the complete connection strings when
requested. makeConnectString() in dlg_specific.c makes connection
strings which are acceptable for specified buffers.

regards,
Hiroshi Inoue

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2014-03-31 04:35:36 Re: issue log message to suggest VACUUM FULL if a table is nearly empty
Previous Message Craig Ringer 2014-03-31 02:30:13 GSoC project suggestion: PIVOT ?

Browse pgsql-odbc by date

  From Date Subject
Next Message Hiroshi Inoue 2014-03-31 03:23:02 Re: FW: ODBC 9.3.0210 not commiting, Discard ALL
Previous Message Michael Paquier 2014-03-28 22:23:22 Re: Re: [HACKERS] New parameter RollbackError to control rollback behavior on error