| From: | David Steele <david(at)pgbackrest(dot)org> |
|---|---|
| To: | Benoit Lobréau <benoit(dot)lobreau(at)dalibo(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | "Andrey M(dot) Borodin" <x4mmm(at)yandex-team(dot)ru>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Fix logging for invalid recovery timeline |
| Date: | 2025-02-22 16:17:44 |
| Message-ID: | 5336e68a-30d0-473f-a0a0-9e61cd9a5a63@pgbackrest.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2/21/25 09:09, Benoit Lobréau wrote:
> On 2/20/25 4:40 PM, David Steele wrote:
>> Benoit -- this was your idea. Did you want to submit a patch yourself?
>
> Here is an attempt at that. I kept the wording I used above. Is it fine
> to repeat the whole ereport block twice?
I think for translation purposes this is probably how it needs to be but
I wonder if we could do something like:
errdetail("Latest checkpoint in %s is at %X/%X <...>",
haveBackupLabel ? "pg_control" ? "backup_label",
I'll defer to Michael on that.
In general this patch and the new messages look good to me, though.
Regards,
-David
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tender Wang | 2025-02-22 17:02:56 | Re: generic plans and "initial" pruning |
| Previous Message | Álvaro Herrera | 2025-02-22 15:51:53 | Re: Simplify the logic a bit (src/bin/scripts/reindexdb.c) |