Re: pgsql: Add -f/--follow option to pg_xlogdump.

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Add -f/--follow option to pg_xlogdump.
Date: 2014-03-26 13:15:41
Message-ID: 5332D2FD.10802@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers


On 03/26/2014 07:50 AM, Heikki Linnakangas wrote:
> Add -f/--follow option to pg_xlogdump.
>
> This is useful for seeing what WAL records are inserted in real-time, by
> pointing pg_xlogdump to a live server.
>
> Branch
> ------
> master
>
> Details
> -------
> http://git.postgresql.org/pg/commitdiff/ce9bb92f8fb8d25cf00ec939797ffdb5930fb792
>
> Modified Files
> --------------
> contrib/pg_xlogdump/pg_xlogdump.c | 31 ++++++++++++++++++++++++++++---
> doc/src/sgml/pg_xlogdump.sgml | 11 +++++++++++
> 2 files changed, 39 insertions(+), 3 deletions(-)
>
>

Seems to have upset Windows (see
<http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=currawong&dt=2014-03-26%2012%3A30%3A44>).

Shouldn't you be using pg_usleep() instead of sleep()?

cheers

andrew

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Heikki Linnakangas 2014-03-26 13:26:12 pgsql: Use pg_usleep() instead of plain sleep(), to fix Windows build
Previous Message Heikki Linnakangas 2014-03-26 11:50:34 pgsql: Add -f/--follow option to pg_xlogdump.