Re: atexit_callback can be a net negative

From: Florian Weimer <fweimer(at)redhat(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: atexit_callback can be a net negative
Date: 2014-03-07 14:23:37
Message-ID: 5319D669.6010405@redhat.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 03/07/2014 06:03 AM, Tom Lane wrote:

> In the bug thread I proposed making atexit_callback check whether getpid()
> still matches MyProcPid. If it doesn't, then presumably we inherited the
> atexit callback list, along with the value of MyProcPid, from some parent
> backend process whose elbow we should not joggle. Can anyone see a flaw
> in that?

There's the PID reuse problem. Forking twice (with a delay) could end
up with the same PID as MyProcPid. Comparing the process start time
would protect against that. Checking getppid() would have the same
theoretical problem.

--
Florian Weimer / Red Hat Product Security Team

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2014-03-07 14:29:30 Re: pg_ctl status with nonexistent data directory
Previous Message Stephen Frost 2014-03-07 14:16:48 Re: extension_control_path