Re: 09.03.0200 test failures

On 02/24/2014 02:08 PM, Christoph Berg wrote:
> Re: To Heikki Linnakangas 2014-02-24 <20140224115931(dot)GD12457(at)msgid(dot)df7cb(dot)de>
>> Re: Heikki Linnakangas 2014-02-19 <5304ADB1(dot)6090306(at)vmware(dot)com>
>>> diff --git a/test/expected/lfconversion.out b/test/expected/lfconversion.out
>>> new file mode 100644
>>> index 0000000..ca4776c
>>> --- /dev/null
>>> +++ b/test/expected/lfconversion.out
>>
>> Hi Heikki,
>>
>> I'm afraid you forgot to update Makefile.am to include that file so it
>> didn't make it into the 09.03.0200 tarball, rendering the testsuite
>> unusable.
>
> After importing the two files into the 09.03.0200 tarball, I'm getting
> regression test failures:

The culprit was this commit:

> commit 2f4f8eabf6ce685c38d69da3e98132b77d38d188
> Author: Hiroshi Inoue <inoue(at)tpf(dot)co(dot)jp>
> Date: Sat Feb 22 12:49:02 2014 +0900
>
> It's safe to lock SC_set_prepared() itself.
>
> diff --git a/statement.c b/statement.c
> index 603a77a..a7dad74 100644
> --- a/statement.c
> +++ b/statement.c
> @@ -683,6 +683,7 @@ SC_set_prepared(StatementClass *stmt, int prepared)
> {
> ConnectionClass *conn = SC_get_conn(stmt);
>
> + ENTER_CONN_CS(conn);
> if (conn && CONN_CONNECTED == conn->status)
> {
> if (CC_is_in_error_trans(conn))

The ENTER_CONN_CS is misplaced; it's before the NULL check on the next
line, so when conn==NULL, it segfaults. I pushed a quick fix for that.

We should wrap a new release quickly. The 09.03.0200 release was quite
broken :-(.

- Heikki