| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Vik Fearing <vik(at)postgresfriends(dot)org> |
| Cc: | Stephen Frost <sfrost(at)snowman(dot)net>, Magnus Hagander <magnus(at)hagander(dot)net>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: password_encryption default |
| Date: | 2020-05-26 08:25:25 |
| Message-ID: | 52ebc049-d2eb-dfe0-0ae2-6e166f16f280@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2020-05-25 17:57, Jonathan S. Katz wrote:
> I took a look over, it looks good. One question on the initdb.c diff:
>
> - if (strcmp(authmethodlocal, "scram-sha-256") == 0 ||
> - strcmp(authmethodhost, "scram-sha-256") == 0)
> - {
> - conflines = replace_token(conflines,
> - "#password_encryption = md5",
> - "password_encryption = scram-sha-256");
> - }
> -
>
> Would we reverse this, i.e. if someone chooses authmethodlocal to be
> "md5", we would then set "password_encryption = md5"?
Yeah, I was too enthusiastic about removing that. Here is a better patch.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Change-default-of-password_encryption-to-scram-sh.patch | text/plain | 4.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2020-05-26 08:28:42 | Re: some grammar refactoring |
| Previous Message | Andy Fan | 2020-05-26 08:22:01 | Make the qual cost on index Filter slightly higher than qual cost on index Cond. |