| From: | Ilia Evdokimov <ilya(dot)evdokimov(at)tantorlabs(dot)com> |
|---|---|
| To: | Alexander Korotkov <aekorotkov(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, "Andrey M(dot) Borodin" <x4mmm(at)yandex-team(dot)ru>, Greg Sabino Mullane <htamfids(at)gmail(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Sample rate added to pg_stat_statements |
| Date: | 2025-01-06 10:50:31 |
| Message-ID: | 52e5e3aa-066a-4daf-8d65-77c34a2f0d98@tantorlabs.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 10.12.2024 17:35, Ilia Evdokimov wrote:
> Hi everyone,
>
> I attached previous sampling patch for pg_stat_statements (v4).
> Suggestions like sampling based on execution time remain unfeasible,
> as pg_stat_statements can track query during query planning, not
> execution.
>
> To evaluate the implementation, I ran a benchmark creating 1,000
> random tables and executing randomized JOIN queries on a small
> machine. When pg_stat_statements enabled, performance decreases, but
> reducing the sampling rate helps mitigate the impact and improves
> performance.
>
> I’d be interested in hearing your new thoughts. Are there areas where
> this patch could be improved, or other ideas worth exploring?
>
> --
> Best regards.
> Ilia Evdokimov,
> Tantor Labs LLC.
I've fixed some small typos in the documentation and in the GUC
description in the attached patch. Any suggestions for improvements?
--
Best regards,
Ilia Evdokimov,
Tantor Labs LLC.
| Attachment | Content-Type | Size |
|---|---|---|
| v6-0001-Allow-setting-sample-ratio-for-pg_stat_statements.patch | text/x-patch | 3.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | John Naylor | 2025-01-06 10:54:29 | Re: Sort functions with specialized comparators |
| Previous Message | Pavel Stehule | 2025-01-06 10:01:17 | Re: Re: proposal: schema variables |