unusual use of "path" in pg_verifybackup?

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: unusual use of "path" in pg_verifybackup?
Date: 2020-09-14 08:57:23
Message-ID: 52cb5c61-3e7f-757f-3dcd-bdb200d5e608@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

pg_verifybackup and the associated backup manifest functionality uses
"path", "path name", etc. throughout where other components might just
say "file", "file name". This isn't wrong, if you follow POSIX
terminology, but it's a bit unusual, I think. Specifically, option
naming like

-i, --ignore=RELATIVE_PATH ignore indicated path
-m, --manifest-path=PATH use specified path for manifest
-w, --wal-directory=PATH use specified path for WAL files

might make one think that there is a search path involved.

Thoughts? Is there a deeper reason behind this, or should we dial this
back a bit perhaps?

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2020-09-14 09:44:54 Re: On login trigger: take three
Previous Message Etsuro Fujita 2020-09-14 08:56:13 Re: problem with RETURNING and update row movement