Re: Terminating pg_basebackup background streamer

From: Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Terminating pg_basebackup background streamer
Date: 2014-02-10 18:29:20
Message-ID: 52F91A80.2010307@vmware.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 02/09/2014 02:17 PM, Magnus Hagander wrote:
> If an error occurs in the foreground (backup) process of pg_basebackup, and
> we exit in a controlled way, the background process (streaming xlog
> process) would stay around and keep streaming.
>
> This can happen for example if disk space runs out and there is very low
> activity on the server. (If there is activity on the server, the background
> streamer will also run out of disk space and exit)
>
> Attached patch kills it off in disconnect_and_exit(), which seems like the
> right thing to do to me.
>
> Any objections to applying and backpatching that for the upcoming minor
> releases?

Do you get a different error message with this patch than before? Is the
new one better than the old one?

- Heikki

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2014-02-10 18:33:45 Re: Memory ordering issue in LWLockRelease, WakeupWaiters, WALInsertSlotRelease
Previous Message Tom Lane 2014-02-10 18:15:53 Re: jsonb and nested hstore