| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | Steeve Lennmark <steevel(at)handeldsbanken(dot)se> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Andreas Karlsson <andreas(at)proxel(dot)se>, Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Relocation of tablespaces in pg_basebackup |
| Date: | 2014-02-08 01:35:03 |
| Message-ID: | 52F589C7.6050804@gmx.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 1/29/14, 12:07 PM, Steeve Lennmark wrote:
> We need to think about how to handle this on platforms without
> symlinks.
> I don't like just printing an error message and moving on. It
> should be
> either pass or fail or an option to choose between them.
>
> I hope someone with experience with those kind of systems can come up
> with suggestions on how to solve that. I only run postgres on Linux.
>
> I would still love some input on this.
Currently, pg_basebackup aborts if it has to create a symlink on a
platform that doesn't support it. So your code that updates the
symlinks would never come into play anyway. I'd just update that code
with a "shouldn't get here" comment and add an exit(1).
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jason Petersen | 2014-02-08 01:46:45 | Re: Move unused buffers to freelist |
| Previous Message | Peter Eisentraut | 2014-02-08 01:10:22 | Re: New option for pg_basebackup, to specify a different directory for pg_xlog |