Re: unixware and --with-ldap

From: "Albe Laurenz" <all(at)adv(dot)magwien(dot)gv(dot)at>
To: <ohp(at)pyrenet(dot)fr>, "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "pgsql-hackers list" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: unixware and --with-ldap
Date: 2006-12-15 08:54:13
Message-ID: 52EF20B2E3209443BC37736D00C3C1380BE7980E@EXADV1.host.magwien.gv.at
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> Here's the diff for configure.in that works for me.

I have a concern about this patch:

> if test "$enable_thread_safety" = yes; then
> # on some platforms ldap_r fails to link without PTHREAD_LIBS
> AC_CHECK_LIB(ldap_r, ldap_simple_bind, [],
> [AC_MSG_ERROR([library 'ldap_r' is required for
LDAP])],
> ! [$PTHREAD_LIBS])
> LDAP_LIBS_FE="-lldap_r"
> else
> ! LDAP_LIBS_FE="-lldap"
> fi
> --- 1122,1139 ----
> if test "$enable_thread_safety" = yes; then
> # on some platforms ldap_r fails to link without PTHREAD_LIBS
> AC_CHECK_LIB(ldap_r, ldap_simple_bind, [],
> [AC_MSG_ERROR([library 'ldap_r' is required for
LDAP])],
> ! [$PTHREAD_LIBS $EXTRA_LDAP_LIBS])
> LDAP_LIBS_FE="-lldap_r"
> else
> ! LDAP_LIBS_FE="-lldap $EXTRA_LDAP_LIBS"
> fi

You left out the case where --enable_thread_safety is specified.
In that case, the frontend has to be linked with libldap_r.so
instead of libldap.so.

Does libldap_r.so _not_ require any extra libraries for linking?

If it does require extra libraries, are they the same as for the
thread-unsafe library (on Linux, that is the case)?

If libldap_r.so does require the same libs, please add $EXTRA_LDAP_LIBS
to the 'LDAP_LIBS_FE="-lldap_r"' line as well.

If libldap_r.so requires different additional libraries, a second
variable would be in place.

Could you test compiling with --enable_thread_safety ?

Yours,
Laurenz Albe

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Albe Laurenz 2006-12-15 09:40:52 Re: Security leak with trigger functions?
Previous Message Hiroshi Saito 2006-12-15 06:48:50 invalid input syntax for type timestamp.