From: | "Albe Laurenz" <all(at)adv(dot)magwien(dot)gv(dot)at> |
---|---|
To: | "Tom Lane *EXTERN*" <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | <pgsql-patches(at)postgresql(dot)org>, <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [HACKERS] Fix linking of OpenLDAP libraries |
Date: | 2006-09-05 06:16:28 |
Message-ID: | 52EF20B2E3209443BC37736D00C3C1380A33E982@EXADV1.host.magwien.gv.at |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
Tom Lane wrote on September 04, 2006:
> "Albe Laurenz" <all(at)adv(dot)magwien(dot)gv(dot)at> writes:
>
>> # The backend doesn't need everything that's in LIBS, however
>> ! LIBS := $(filter-out -lz -lreadline -ledit -ltermcap -lncurses
-lcurses -lldap_r $(PTHREAD_LIBS), $(LIBS))
>
> This seems pretty risky. What if PTHREAD_LIBS contains -L switches?
> They'd get removed even if needed for other libraries.
>
> It would probably be safer not to put LDAP into LIBS at all, but
invent
> two new macros for configure to set, say LDAP_LIBS and LDAP_LIBS_R,
> and add these to the link lines in the backend and libpq respectively.
That seems like a good idea.
I'll try to work it out and resubmit the fix.
Yours,
Laurenz Albe
From | Date | Subject | |
---|---|---|---|
Next Message | Victor Wagner | 2006-09-05 06:17:15 | Re: [PATCHES] Backend SSL configuration enhancement |
Previous Message | Andrew - Supernews | 2006-09-05 06:09:07 | Re: [HACKERS] DOC: catalog.sgml |
From | Date | Subject | |
---|---|---|---|
Next Message | Victor Wagner | 2006-09-05 06:17:15 | Re: [PATCHES] Backend SSL configuration enhancement |
Previous Message | Andrew - Supernews | 2006-09-05 06:09:07 | Re: [HACKERS] DOC: catalog.sgml |