| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Mitsumasa KONDO <kondo(dot)mitsumasa(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_basebackup and pg_stat_tmp directory |
| Date: | 2014-02-02 21:57:28 |
| Message-ID: | 52EEBF48.70608@gmx.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2/2/14, 10:23 AM, Fujii Masao wrote:
> I'm thinking to change basebackup.c so that it compares the
> name of the directory that it's trying to back up and the setting
> value of log_directory parameter, then, if they are the same,
> it just skips the directory. The patch that I sent upthread does
> this regarding stats_temp_directory.
I'm undecided on whether log files should be copied, but in case we
decide not to, it needs to be considered whether we at least recreate
the pg_log directory on the standby. Otherwise weird things will happen
when you start the standby, and it would introduce an extra fixup step
to sort that out.
Extra credit for doing something useful when pg_log is a symlink.
I fear, however, that if you end up implementing all that logic, it
would become too much special magic.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2014-02-02 22:50:39 | Re: mvcc catalo gsnapshots and TopTransactionContext |
| Previous Message | Tom Lane | 2014-02-02 21:53:12 | Re: [COMMITTERS] pgsql: Include planning time in EXPLAIN ANALYZE output. |