Re: git-review: linking commits to review discussion in git

From: Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>
To: Murtuza Mukadam <murtuza(dot)i(dot)mukadam(at)gmail(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: git-review: linking commits to review discussion in git
Date: 2014-01-28 07:10:45
Message-ID: 52E757F5.9080103@vmware.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 01/27/2014 11:36 PM, Murtuza Mukadam wrote:
> Hello All,
> We have linked peer review discussions on
> 'pgsql-hackers' to their respective commits within the main
> postgresql.git repository. You can view the linked reviews from 2012
> until present in the GitHub repo at
> https://github.com/mmukadam/postgres/tree/review
>
> If you want to work with these reviews locally, you can use our
> git-review tool. It allows you to create reviews and attach them to
> commits in git. We didn't modify git, instead we added some scripts
> that use standard git commands. git-review is beta, but since it only
> adds a detached 'review' branch and modifies the contents of this
> branch, it has minimal impact and can easily be removed by deleting
> the 'review' branch and scripts.
>
> The online man-page is here:
> http://users.encs.concordia.ca/~m_mukada/git-review.html
>
> In order to install git-review, you need to clone the repository:
> https://github.com/mmukadam/git-review.git
>
> The online tutorial is available here:
> http://users.encs.concordia.ca/~m_mukada/git-review-tutorial.html
>
> The clone of postgresql.git with linked review discussion is here (new
> review discussion are linked nightly)
> https://github.com/mmukadam/postgres
>
> This work is part of my Master's thesis. If you'd like us to change
> the tool to better suit your review process, have another git repo
> you'd like us to link commits with review discussion, or have other
> feedback, please let us know.

I don't understand what this does. The repository at
https://github.com/mmukadam/postgres looks like just a clone of the main
PostgreSQL repository, with no extra links anywhere. And the repository
at https://github.com/mmukadam/postgres/tree/review looks like a mailing
list archive turned into a git repository, but I don't see any links to
the commits in the main repository there.

Am I missing something?

- Heikki

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2014-01-28 07:20:59 Re: Fix comment typo in /src/backend/command/cluster.c
Previous Message David Fetter 2014-01-28 06:58:16 Re: Fix comment typo in /src/backend/command/cluster.c