From: | "Wu, Fei" <wufei(dot)fnst(at)cn(dot)fujitsu(dot)com> |
---|---|
To: | "pgsql-bugs(at)lists(dot)postgresql(dot)org" <pgsql-bugs(at)lists(dot)postgresql(dot)org> |
Subject: | Typo in execParallel.c |
Date: | 2019-06-03 10:26:05 |
Message-ID: | 52E6E0843B9D774C8C73D6CF64402F05622146EB@G08CNEXMBPEKD02.g08.fujitsu.local |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs |
Hi, all
Lately I was reading Parallelism of Postgres, and I was confused when reading the comment of function ExecParallelEstimate :
----------------------------------------------
* While we're at it, count the number of PlanState nodes in the tree, so
* we know how many SharedPlanStateInstrumentation structures we need.
static bool
ExecParallelEstimate(PlanState *planstate, ExecParallelEstimateContext *e)
----------------------------------------------
The structure SharedPlanStateInstrumentation is not exists at all. And I noticed that the so called “SharedPlanStateInstrumentation”
maybe is the structure Instrumentation now, which is used for storing information of planstate in parallelism.
So, I think the comment is out of date now, isn’t it?
Maybe we can modified it from “SharedPlanStateInstrumentation” to “Instrumentation” for clear
--
Best Regards
-----------------------------------------------------
Wu Fei
Development Department II
Software Division III
Nanjing Fujitsu Nanda Software Tech. Co., Ltd.(FNST)
ADDR.: No.6 Wenzhu Road, Software Avenue,
Nanjing, 210012, China
TEL : +86+25-86630566-9356
COINS: 7998-9356
FAX: +86+25-83317685
MAIL:wufei(dot)fnst(at)cn(dot)fujitsu(dot)com
http://www.fujitsu.com/cn/fnst/
---------------------------------------------------
From | Date | Subject | |
---|---|---|---|
Next Message | Ahmed MARFOUK | 2019-06-03 15:22:20 | ste application name for psql command line query |
Previous Message | Sandeep Thakkar | 2019-06-03 10:00:49 | Re: BUG #15789: libpq compilation with OpenSSL 1.1.1b fails on Windows with Visual Studio 2017 |