Re: Postgresql for cygwin - 3rd

From: Marco Atzeri <marco(dot)atzeri(at)gmail(dot)com>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Postgresql for cygwin - 3rd
Date: 2014-01-25 22:32:57
Message-ID: 52E43B99.9080201@gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 25/01/2014 22:42, Marco Atzeri wrote:
> On 25/01/2014 19:23, Andrew Dunstan wrote:
>>
>> On 01/24/2014 07:50 AM, Marco Atzeri wrote:

>>
>> * LDAP libraries - the way you have proposed surely isn't right. What
>> we want is something more like this in the Makefile.global.in:
>> ifeq ($(PORTNAME), cygwin)
>> libpq_pgport += $(LDAP_LIBS_FE)
>> endif
>
> I will test in this way. I have no preferance on
> the implemented solution.
>

your proposal builds fine.
----------------------------------------------------------------
--- origsrc/postgresql-9.3.2/src/Makefile.global.in 2013-12-02
21:57:48.000000000 +0100
+++ src/postgresql-9.3.2/src/Makefile.global.in 2014-01-25
22:46:36.484816700 +0100
@@ -508,6 +508,11 @@ ifeq ($(PORTNAME),win32)
LIBS += -lws2_32 -lshfolder
endif

+# missing for link on cygwin ?
+ifeq ($(PORTNAME),cygwin)
+libpq_pgport += $(LDAP_LIBS_FE)
+endif
+
# Not really standard libc functions, used by the backend.
----------------------------------------------------------------

Of course no difference on test results, as expected

Attached full patch as I am currently testing on 9.3.2

Regards
Marco

Attachment Content-Type Size
postgresql-9.3.2-2.src.patch text/plain 4.5 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephen Frost 2014-01-25 22:33:46 Re: A better way than tweaking NTUP_PER_BUCKET
Previous Message Andres Freund 2014-01-25 22:29:14 Re: A minor correction in comment in heaptuple.c