Questionable coding in orderedsetaggs.c

From: Jeremy Harris <jgh(at)wizmail(dot)org>
To: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Questionable coding in orderedsetaggs.c
Date: 2014-01-25 18:25:19
Message-ID: 52E4018F.8090606@wizmail.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

In ordered_set_startup() sorts are initialised in non-randomAccess mode
(tuplesort_begin_heap() and ~datum(), last argument).

The use of tuplesort_skip_tuples() feels very like a random access to
me. I think it doesn't fail because the only use (and implementation)
is to skip forwards; if backwards were tried (as the interface permits)
external sorts would fail because multiple tapes are present for
FINALMERGE.
--
Cheers,
Jeremy

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2014-01-25 19:04:29 Re: Storing pg_stat_statements query texts externally, pg_stat_statements in core
Previous Message Andrew Dunstan 2014-01-25 18:23:07 Re: Postgresql for cygwin - 3rd