Re: Incorrectly reporting config errors

On 01/21/2014 12:29 PM, Robert Haas wrote:
> On Tue, Jan 21, 2014 at 1:59 PM, Thom Brown <thom(at)linux(dot)com> wrote:
>> On 21 January 2014 18:35, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> Thom Brown <thom(at)linux(dot)com> writes:
>>>> I'm getting a report of a config error when changing a config value
>>>> that requires a restart:
>>>> ...
>>>> 2014-01-21 18:14:53 GMT [28718]: [4-1] user=,db=,client= LOG:
>>>> received SIGHUP, reloading configuration files
>>>> 2014-01-21 18:14:53 GMT [28718]: [5-1] user=,db=,client= LOG:
>>>> parameter "max_connections" cannot be changed without restarting the
>>>> server
>>>> 2014-01-21 18:14:53 GMT [28718]: [6-1] user=,db=,client= LOG:
>>>> configuration file "/home/thom/Development/data/postgresql.conf"
>>>> contains errors; unaffected changes were applied
>>>
>>>> It doesn't contain errors.
>>>
>>> Yeah it does: it's got a value that can't be applied. I think you're
>>> making a semantic quibble.
>>
>> I see it as technically wrong. There's nothing wrong with my config
>> file. A reload of the file may not be able to apply all the settings,
>> but there's no typo or mistake anywhere in my file. I would just need
>> to restart instead of reload.
>>
>> However, given that you find it unsurprising, I'll leave it there.
>
> I kind of agree with Thom. I understand why it's doing what it's
> doing, but it still seems sort of lame.

Though I am not sure why it is lame when it seems to be following
protocol; announce the problem, then tell where it originates. Seems
like useful information to me.

postgres-2014-01-21 14:39:54.738 PST-0ERROR: parameter
"max_connections" cannot be changed without restarting the server
postgres-2014-01-21 14:39:54.738 PST-0STATEMENT: SET max_connections=99;

-2014-01-21 14:42:23.166 PST-0LOG: received SIGHUP, reloading
configuration files
-2014-01-21 14:42:23.168 PST-0LOG: parameter "max_connections" cannot
be changed without restarting the server
-2014-01-21 14:42:23.169 PST-0LOG: configuration file
"/usr/local/pgsql93/data/postgresql.conf" contains errors; unaffected
changes were applied

--
Adrian Klaver
adrian(dot)klaver(at)gmail(dot)com